This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH][LTO][RFC] AR archive support for LTO


Andrew Pinski <pinskia@gmail.com> writes:

> On Tue, Nov 3, 2009 at 3:02 PM, Cary Coutant <ccoutant@google.com> wrote:
>
>> + Âoff_t offset;
>> ...
>> + Â Â Âsscanf(offset_p, "%" PRId64, &offset);
>>
>> Same problem as above; I don't think there's a portable format
>> specifier for off_t. I'd suggest declaring offset as int64_t here and
>> casting to off_t when you need it, or assigning it to an off_t after
>> the sscanf.
>
> SCNd64 is the correct usage for sscanf but can't we have a atoll for
> int64_t ?  Or rather why don't we use HWI here?
> On darwin with -Werror turned on I get the following error:
> /Users/apinski/src/local/gcc/gcc/lto/lto-elf.c:561:7: error: ISO C
> does not support the 'q' gnu_scanf length modifier

Please be careful here: you need to provide a replacement for platforms
that lack PRId64/SCNd64, cf. PR bootstrap/41996.

     Rainer

-- 
-----------------------------------------------------------------------------
Rainer Orth, Center for Biotechnology, Bielefeld University


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]