Re: [PATCH] Fix MIPS LHX in mips-dsp.md

[Richard Sandiford <rdsandiford at googlemail dot com>]

"Fu, Chao-Ying" <fu@mips.com> writes:
> Though I don't think the original GCC tests will be affected by this patch,
> I will re-run GCC tests.

Thanks, that was all I was really asking about.  I should have been more
specific, sorry.

There's a general GCC rule that code patches must be regression-tested
against the full GCC testsuite (or at least all the parts associated
with the languages that your target supports by default).  The idea
is to make sure that no existing tests start to fail after the patch.
If you're confident they won't (and I agree they're unlikely to in
this case), well, all the better!  It should just be a formality.

Also, if you're submitting a patch for trunk (say), you must test
the patch against trunk, rather than a vendor toolchain like you
were doing.

Submitters are supposed to say which target they regression-tested
against when posting the patch for review.  If you're submitting a
patch for both trunk and branches, I think it's OK to just test trunk
for the initial submission.  Then, if the patch gets approved,
you should retest on the branches before committing there.

So really, my message was trying to "gently" prod you in that direction. ;)

Anyway, thanks for catching this.  The patch is OK for trunk if applying
the patch to trunk introduces no regressions in the testsuite.  It's also
OK for 4.4 if the patch introduces no regressions there.

Richard