This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [patch][graphite] Check cloog revision when configure.


On Fri, 2009-11-06 at 13:56 -0600, Sebastian Pop wrote:
> On Fri, Nov 6, 2009 at 12:59, Paolo Bonzini <bonzini@gnu.org> wrote:
> > If this is the patch:
> >
> > -  #if CLOOG_VERSION_MAJOR != 0 || CLOOG_VERSION_MINOR != 15
> > +  #if CLOOG_VERSION_MAJOR != 0 || CLOOG_VERSION_MINOR != 15 ||
> > CLOOG_VERSION_REVISION < 5
> >   choke me
> >   #endif
> >
> > it is fine as is, however consider future proofing it by allowing 0.16 and
> > 1.0 to pass the test.
> 
> I do not think that CLooG 0.16 will be compatible with CLooG-PPL 0.15.
> At least the changes that I saw in the patches that Tobias prepared
> would simply not compile with the code of Graphite that is in trunk
> and branch right now.  So please leave the hard checks for major
> and minor versions.

Yep, as we want to unify the interface of our cloog and the CLooG of
cloog.org and we decided to adapt the cloog.org interface there will not
be any compatibility. However these changes will come with the next gcc
release.

Tobi


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]