This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [gc-improv] Move tree-ssa-strucalias.c:heapvar_for_stmt to obstack


On Sun, Nov 1, 2009 at 8:06 AM, Laurynas Biveinis
<laurynas.biveinis@gmail.com> wrote:
> One less GGC_NEW.
>
> Bootstrapped and regtested under x86_64-unknown-linux-gnu, commited to
> gc-improv.

I don't think this patch is safe.  This is a mapping from tree to heapvar,
so if tree is GCed and then re-used we get bogus lookups here.  Note
this mapping is live throughout the whole compilation!

Richard.

> 2009-11-01 ?Laurynas Biveinis ?<laurynas.biveinis@gmail.com>
>
> ? ? ? ?* tree-ssa-structalias.c (heapvar_for_stmt): Remove GTY marker.
> ? ? ? ?(heapvar_map_obstack): New variable.
> ? ? ? ?(struct heapvar_map): Remove GTY marker.
> ? ? ? ?(heapvar_insert): Use obstack allocation.
> ? ? ? ?(get_constraint_for_1): Remove duplicated prototype.
> ? ? ? ?(heapvar_htab_alloc): New function.
> ? ? ? ?(init_alias_heapvars): Initialize heapvar_map_obstack. ?Use it for
> ? ? ? ?heapvar_for_stmt element allocation.
> ? ? ? ?(delete_alias_heapvars): Free heapvar_map_obstack.
> ? ? ? ?(gt-tree-ssa-structalias.h): Remove include.
> ? ? ? ?* Makefile.in (tree-ssa-structalias.o): Remove
> ? ? ? ?gt-tree-ssa-structalias.h dependency.
> ? ? ? ?(GTFILES): Remove gt-tree-ssa-structalias.h
>
> --
> Laurynas
>


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]