This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] Add missing parens

From: Kai Tietz <ktietz70 at googlemail dot com>
To: Eric Botcazou <ebotcazou at adacore dot com>
Cc: gcc-patches at gcc dot gnu dot org, obry at adacore dot com, Dave Korn <dave dot korn dot cygwin at googlemail dot com>
Date: Tue, 20 Oct 2009 21:27:02 +0200
Subject: Re: [PATCH] Add missing parens
References: <4ADB6743.4090105@adacore.com> <4ADDFE10.9080406@adacore.com> <90baa01f0910201152r38d06f9cx33b8066433a5f4bf@mail.gmail.com> <200910202118.04857.ebotcazou@adacore.com>

2009/10/20 Eric Botcazou <ebotcazou@adacore.com>:
>> Ok, applied to trunk with some minor changes to line-length at revision
>> 153033.
>
> Not clear why; morever they are not correct, the indentation is 2 spaces.

The indentation I kept, if you want you can correct it. The issue is,
that using macro DWARF_FRAME_REGNUM in case of example in dwarf2out.c
' if (DWARF_FRAME_REGNUM (i) == DWARF_FRAME_RETURN_COLUMN)' could
leads to wrong code. As there is a semantic difference between
'if ((TARGET_64BIT ? dbx64_register_map[i] : svr4_dbx_register_map[i])
== DWARF_FRAME_RETURN_COLUMN)
and
if (TARGET_64BIT ? dbx64_register_map[i] : svr4_dbx_register_map[i] ==
DWARF_FRAME_RETURN_COLUMN)


Cheers,
Kai

-- 
|  (\_/) This is Bunny. Copy and paste
| (='.'=) Bunny into your signature to help
| (")_(") him gain world domination

Follow-Ups:
- Re: [PATCH] Add missing parens
  - From: Eric Botcazou

References:
- [PATCH] Add missing parens
  - From: Pascal Obry
- Re: [PATCH] Add missing parens
  - From: Pascal Obry
- Re: [PATCH] Add missing parens
  - From: Kai Tietz
- Re: [PATCH] Add missing parens
  - From: Eric Botcazou

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]