This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH, i386]: Implement SImode/DImode setcc insn patterns

2009/10/12 Paolo Bonzini <bonzini@gnu.org>:
> On 10/10/2009 10:12 PM, Uros Bizjak wrote:
>>
>> And for TARGET_PARTIAL_REG_STALL:
>>
>>     ...
>>     call    __netf2
>>     xorl    %eax, %eax
>>     leave
>>     setne    %al
>>     ret
>
> Doesn't the xor clobber the flags here?

Ugh, indeed.  Fixed by attached patch to generate:

        ...
        call    __netf2
        addl    $32, %esp
        leave
        testl   %eax, %eax
        movl    $0, %eax
        setne   %al
        ret

2009-10-12  Uros Bizjak  <ubizjak@gmail.com>

	* config/i386/i386.md (*setcc_<mode>_2): Do not use ix86_expand_clear
	to zero operand 0.

Patch was tested on x86_64-pc-linux-gnu, committed to SVN mainline.

Thanks for spotting this!

Uros.

Attachment: p.diff.txt
Description: Text document

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]