This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [patch] Change argument name

From: Rafael Espindola <espindola at google dot com>
To: Ian Lance Taylor <iant at google dot com>
Cc: GCC Patches <gcc-patches at gcc dot gnu dot org>, Cary Coutant <ccoutant at google dot com>
Date: Fri, 9 Oct 2009 09:27:52 -0400
Subject: Re: [patch] Change argument name
References: <38a0d8450910080834r48bf631esdd4526461c04b446@mail.gmail.com> <mcrd44xh11j.fsf@dhcp-172-17-9-151.mtv.corp.google.com>

> There was no actual patch in this message.

Sorry about that. Attached now.

> I think that for a header file like this it's OK to use parameter
> names. ÂA header file like this is already susceptible to macro
> breakage in that it defines struct fields.

So, is the patch OK?

> Ian
>

Cheers,
-- 
Rafael Ãvila de EspÃndola

Index: include/plugin-api.h
===================================================================
--- include/plugin-api.h	(revision 152561)
+++ include/plugin-api.h	(working copy)
@@ -218,7 +218,7 @@
 
 typedef
 enum ld_plugin_status
-(*ld_plugin_add_input_library) (char *pathname);
+(*ld_plugin_add_input_library) (char *libname);
 
 /* The linker's interface for issuing a warning or error message.  */

Follow-Ups:
- Re: [patch] Change argument name
  - From: Ian Lance Taylor

References:
- [patch] Change argument name
  - From: Rafael Espindola
- Re: [patch] Change argument name
  - From: Ian Lance Taylor

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]