Re: [patch] bug fix for gengtype in plugin mode

[Diego Novillo <dnovillo at google dot com>]

On Wed, Sep 23, 2009 at 18:12, Rafael Espindola <espindola@google.com> wrote:

> @@ -3657,8 +3658,17 @@ main (int argc, char **argv)
>      {
>        srcdir = argv[2];
>        inputlist = argv[3];
> -      plugin_files = argv+4;
>        nb_plugin_files = argc-4;
> +      plugin_files = XNEWVEC (char *, nb_plugin_files);

s/XNEWVEC/XCNEWVEC/

> +      for (i = 0; i < nb_plugin_files; i++)
> +      {
> +        /* Place an all zero lang_bitmap before the plugin file
> +	   name.  */
> +        char *name = argv[i + 4];
> +        int len = strlen(name) + 1 + sizeof (lang_bitmap);
> +        plugin_files[i] = ((char *)xcalloc (len, sizeof(char))) + sizeof (lang_bitmap);

space after '(char *)'.  Line is too long.

Thanks for the fix.  Patch is OK with those changes.


Diego.