This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH PING 2/5] Named address spaces: support multiple pointer modes
- From: "Joseph S. Myers" <joseph at codesourcery dot com>
- To: Ulrich Weigand <uweigand at de dot ibm dot com>
- Cc: Richard Henderson <rth at redhat dot com>, Richard Guenther <richard dot guenther at gmail dot com>, gcc-patches at gcc dot gnu dot org
- Date: Tue, 22 Sep 2009 23:20:53 +0000 (UTC)
- Subject: Re: [PATCH PING 2/5] Named address spaces: support multiple pointer modes
- References: <200909222250.n8MMo1Lp009357@d12av02.megacenter.de.ibm.com>
On Wed, 23 Sep 2009, Ulrich Weigand wrote:
> Note that this patch applies to the branch; mainline currently
> contains neither of the includes. So this basically only changes
> the resulting mainline patch into adding #include "target-def.h"
> instead of adding #include "targhooks.h" ...
>
> It seemed to me that of the two, target-def.h was a more natural
> place for the new macro. If you have a better suggestion where
> to place it, I'll be happy to do so ...
target-def.h should only be included in the target-specific .c files that
define the target structure using an initializer whose default values come
from target-def.h; no file not defining such an initializer should include
it. (c-common.c includes it to define the default C-family target
structure initializer. I don't know why df-scan.c includes it, but it is
wrong to do so.)
If you think you need it elsewhere, you may be putting a macro in
target-def.h that is not the default value of an initializer for the
target structure and so does not belong there.
--
Joseph S. Myers
joseph@codesourcery.com