This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [patch 14/36][m32c] Hookize static chain and trampoline macros

From: Richard Henderson <rth at redhat dot com>
To: DJ Delorie <dj at redhat dot com>
Cc: gcc-patches at gcc dot gnu dot org
Date: Mon, 21 Sep 2009 15:52:28 -0700
Subject: Re: [patch 14/36][m32c] Hookize static chain and trampoline macros
References: <4AB7F353.3060707@redhat.com> <4AB800BE.3010002@redhat.com> <200909212247.n8LMlAIA020825@greed.delorie.com>

On 09/21/2009 03:47 PM, DJ Delorie wrote:

A straight-forward conversion to hooks.


Why the change from "tramp" to "m_tramp" ?  If we're worried about
political correctness, use "trampoline".


"tramp" was a raw address.
"m_tramp" is a MEM with all the proper MEM_ATTRS set.

I consistently changed the variable name to (1) make that clear and (2) catch any incomplete conversion problems.

r~

Follow-Ups:
- Re: [patch 14/36][m32c] Hookize static chain and trampoline macros
  - From: DJ Delorie

References:
- [patch 01/36] Hookize static chain and trampoline macros
  - From: Richard Henderson
- [patch 14/36][m32c] Hookize static chain and trampoline macros
  - From: Richard Henderson
- Re: [patch 14/36][m32c] Hookize static chain and trampoline macros
  - From: DJ Delorie

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]