This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [RFA] Implement DW_TAG_*_parameter_pack

On 09/17/2009 12:14 PM, Dodji Seketeli wrote:
Le 16/09/2009 18:45, Jason Merrill a écrit : 
Is FUNCTION_PARAMETER_PACK_P really true for a PARM_DECL generated from
a function parameter pack?  That seems wrong.


Yes it is. I think  It comes from tsubst_decl, in the PARM_DECL case:
             r = copy_node (t);<--- we copy the pack node here so the copy
has the FUNCTION_PARAMETER_PACK_P set too.

Should I unset it ?

Yes, please.

+       So here, we just check that naming pattern. Is there a better
way ?  */

Typo "string", extra space before ?

Typo fixed. I don't understand what you mean by "extra space before", sorry.

Remove the space between "way" and "?", it's not customary to put a space there in English.

Jason

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]