This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH PING] Add support for the Win32 hook prologue


2009/9/17 Stefan Dösinger <stefan@codeweavers.com>:
> Am Thursday 17 September 2009 15:27:34 schrieb Kai Tietz:
>> + ? ? ?insn = emit_insn (gen_vswapmov (gen_rtx_REG (Pmode, DI_REG),
>> gen_rtx_REG (Pmode, DI_REG)));
>> Use here not Pmode. Use SImode.
> Ok, the obvious question is: What's the difference.
>
>> As there is no gen_vswapmov for x86_64
>> case in i386.md with rule of DI registers.
> The patch doesn't need it, since this attribute is (for now) 32 bit only,
> ix86_function_ms_hook_prologue() checks for that. Or should I add one just in
> case some code uses it later? I think a 64 bit vswapmov would be dead code
> for now.
>

vswapmov expects explicit SImode. So better write it there (just in
i386.c). As otherwise maybe somebody misinterprets this and thinks it
can handle DImode, which btw would lead to an assembler failure, as
movl.s doesn't handle 64-bit register.

Kai

-- 
|  (\_/) This is Bunny. Copy and paste
| (='.'=) Bunny into your signature to help
| (")_(") him gain world domination


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]