This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: dwarf2out tree expression expansion improvements


On Mon, 14 Sep 2009, Jan Hubicka wrote:

> > Hi,
> > this is updated patch that applies post VTA merge.
> > Alexandre, most of merging was trivial, only non-trivial change was
> > needed to dw_loc_list that is essentially code broken out of
> > add_location_or_const_value_attribute.  I hope I backported everything
> > correctly, but it would be nice if you could check.
> 
> Hi,
> I would like to ping this patch.  There are number of dwarf2out tree
> expansion changes I would like to merge that are dependent on this.

+       /* TODO: We can handle this case via OP_piece of dwarf stack 
machine operatoins.
+        It should not be common case however.  */
+       if (dump_file)
+       {
+         fprintf (stderr, "Multipart value can not be used in value 
expression.\n");
+       }

this is certainly bogus.  Add at least && (dump_flags & TDF_details)
and dump to dump_file, not stderr.  The {} braces are also superfluous.

Same for all other dump stuff - I think the "FOO in the expression" hunks
are not useful, so please remove them.

I'm not into the dwarf2out stuff too much so I'd like someone else
review and approve the patch.

Richard.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]