This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Add support for the Win32 hook prologue (try 2)


On 09/10/2009 11:46 PM, Stefan Dösinger wrote:
Am Thursday 10 September 2009 23:23:13 schrieb Paolo Bonzini:
+/* { dg-do run } */
+/* { dg-options "-O2 -fomit-frame-pointer -m32" } */

This is not exactly what I suggested, and there are a few imprecisions
in the formatting.

If the patch is accepted though I can commit it and fix these.
I have chosen that because as far as I could see dg-require-effective-target
ilp32 skips on x86_64. This was inconvenient for me because I have(with
default options) a x86_64 compiler and I was too lazy to look up how to
change that, or run the tests with i386. I also thought it handy that the
test would be run on more platforms, especially considering that many wine
users are compiling on a x86_64 platform with -m32. So it gets closer to the
actual use case.

The testsuite can be run multiple times with different options. For x86-64 it is common to do this to test with and without -m32 (thus testing both 32-bit and 64-bit mode). In this case dg-require-effective-target will skip the 64-bit test; it is awfully underdocumented, though.


Paolo


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]