Re: [PATCH] Add support for the Win32 hook prologue (try 2)

[Stefan Dösinger <stefan at codeweavers dot com>]

Am Thursday 10 September 2009 23:23:13 schrieb Paolo Bonzini:
> +/* { dg-do run } */
> +/* { dg-options "-O2 -fomit-frame-pointer -m32" } */
>
> This is not exactly what I suggested, and there are a few imprecisions
> in the formatting.
>
> If the patch is accepted though I can commit it and fix these.
I have chosen that because as far as I could see dg-require-effective-target 
ilp32 skips on x86_64. This was inconvenient for me because I have(with 
default options) a x86_64 compiler and I was too lazy to look up how to 
change that, or run the tests with i386. I also thought it handy that the 
test would be run on more platforms, especially considering that many wine 
users are compiling on a x86_64 platform with -m32. So it gets closer to the 
actual use case.
(As far as I can see, i386.exp already filters out targets that are neither 
i?86 nor x86_64)

That said, I don't care too much about the test case personally. I could also 
use the dg-require-effective-target, as long as the functionality gets at 
least some test coverage.