This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
PATCH to gnu_unique_object configury
- From: Jason Merrill <jason at redhat dot com>
- To: gcc-patches List <gcc-patches at gcc dot gnu dot org>
- Date: Thu, 10 Sep 2009 01:14:02 -0400
- Subject: PATCH to gnu_unique_object configury
I misunderstood how the "extra testing logic" argument to
gcc_GAS_CHECK_FEATURE works; apparently it isn't used for an in-tree
assembler. So I need to do the glibc check in the "command if feature
available" argument instead.
Fixes mistaken enabling on i386-unknown-freebsd7.2. Committed to trunk
as obvious.
commit cfd2bae04350f0ad7dc16f74f93f1116cc75fc04
Author: Jason Merrill <jason@redhat.com>
Date: Wed Sep 9 10:35:04 2009 -0400
* configure.ac: Check glibc version even if we have an in-tree
assembler.
diff --git a/gcc/configure b/gcc/configure
index 2db7cf2..3cfc903 100755
--- a/gcc/configure
+++ b/gcc/configure
@@ -23985,16 +23985,7 @@ fi
$as_echo "$as_me:${as_lineno-$LINENO}: \$? = $ac_status" >&5
test $ac_status = 0; }; }
then
- # Also check for ld.so support, i.e. glibc 2.11 or higher.
- if test x$host = x$build -a x$host = x$target &&
- glibcver=`ldd --version 2>/dev/null`; then
- glibcmajor=`expr "$glibcver" : "ldd (GNU libc) \([0-9]*\)"`
- glibcminor=`expr "$glibcver" : "ldd (GNU libc) [0-9]*\.\([0-9]*\)"`
- glibcnum=`expr $glibcmajor \* 1000 + $glibcminor`
- if test "$glibcnum" -ge 2011 ; then
- gcc_cv_as_gnu_unique_object=yes
- fi
- fi
+ gcc_cv_as_gnu_unique_object=yes
else
echo "configure: failed program was" >&5
cat conftest.s >&5
@@ -24005,7 +23996,16 @@ fi
{ $as_echo "$as_me:${as_lineno-$LINENO}: result: $gcc_cv_as_gnu_unique_object" >&5
$as_echo "$gcc_cv_as_gnu_unique_object" >&6; }
if test $gcc_cv_as_gnu_unique_object = yes; then
- enable_gnu_unique_object=yes
+ # Also check for ld.so support, i.e. glibc 2.11 or higher.
+ if test x$host = x$build -a x$host = x$target &&
+ glibcver=`ldd --version 2>/dev/null`; then
+ glibcmajor=`expr "$glibcver" : "ldd (GNU libc) \([0-9]*\)"`
+ glibcminor=`expr "$glibcver" : "ldd (GNU libc) [0-9]*\.\([0-9]*\)"`
+ glibcnum=`expr $glibcmajor \* 1000 + $glibcminor`
+ if test "$glibcnum" -ge 2011 ; then
+ enable_gnu_unique_object=yes
+ fi
+ fi
fi
fi
diff --git a/gcc/configure.ac b/gcc/configure.ac
index f613871..b8ec90e 100644
--- a/gcc/configure.ac
+++ b/gcc/configure.ac
@@ -3391,7 +3391,7 @@ Valid choices are 'yes' and 'no'.]) ;;
esac],
[gcc_GAS_CHECK_FEATURE([gnu_unique_object], gcc_cv_as_gnu_unique_object,
[elf,2,19,52],,
- [.type foo, @gnu_unique_object],
+ [.type foo, @gnu_unique_object],,
# Also check for ld.so support, i.e. glibc 2.11 or higher.
[if test x$host = x$build -a x$host = x$target &&
glibcver=`ldd --version 2>/dev/null`; then
@@ -3399,10 +3399,9 @@ Valid choices are 'yes' and 'no'.]) ;;
glibcminor=`expr "$glibcver" : "ldd (GNU libc) [[0-9]]*\.\([[0-9]]*\)"`
glibcnum=`expr $glibcmajor \* 1000 + $glibcminor`
if test "$glibcnum" -ge 2011 ; then
- gcc_cv_as_gnu_unique_object=yes
+ enable_gnu_unique_object=yes
fi
- fi],
- [enable_gnu_unique_object=yes])])
+ fi])])
if test x$enable_gnu_unique_object = xyes; then
AC_DEFINE(HAVE_GAS_GNU_UNIQUE_OBJECT, 1,
[Define if your assembler supports @gnu_unique_object.])