This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [patch darwin] updated patch fixes PR41296, PR41245 (also re-enable checking removed in PR41224, PR41237)


Thanks Alexandre,
On 9 Sep 2009, at 08:23, Alexandre Oliva wrote:

On Sep 8, 2009, IainS <developer@sandoe-acoustics.co.uk> wrote:

Index: contrib/compare-debug
<snip>
Please use `uname -s` instead of $(uname -s), for portability.

Also, please follow the indentation style of the script. Use two- blanks
indentation, and align case with the alternative, like this:


case `uname -s` in
Darwin)
  ld -S ...
  ;;
*)
  cp ...
  ;;
esac

Given a suitable ChangeLog entry and these changes, this is approved.

thanks for the review; new patch attached with those changes; proposed changelog entry below.
Hopefully, some kind person will commit this for us.
Iain


----

Iain Sandoe <iain.sandoe@sandoe-acoustics.co.uk>

*compare-debug: handle stripping of dwarf debug sections from darwin mach-o objects

---

Attachment: cmpdbg-2.diff.txt
Description: Text document




Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]