This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: PR debug/29232 [VTA] move assign rather than debug stmt in phiopt
On Fri, Sep 4, 2009 at 8:25 PM, Alexandre Oliva<aoliva@redhat.com> wrote:
> On Sep ?4, 2009, Richard Guenther <richard.guenther@gmail.com> wrote:
>
>> On Thu, Sep 3, 2009 at 11:22 PM, Alexandre Oliva<aoliva@redhat.com> wrote:
>>> tree-ssa-phiopt.c's minmax replacement will sometimes attempt to move
>>> the only non-debug stmt in a block to another block. ?The assumption
>>> that the assignment to be moved is the last in the block is correct only
>>> if there aren't any debug stmts after it. ?In the presented testcase,
>>> there is, and so we ended up moving the debug stmt rather than the
>>> assignment. ?Then, when the block with the assignment was removed,
>>> verify_ssa noticed something was broken.
>>>
>>> The obvious fix is to skip debug stmts at the end of the block before
>>> moving the assignment. ?Unless someone objects, I'll check this in as
>>> obvious once my testing is completed.
>
>> you added gsi_last_nondebug_bb, why not use that?
>
> Err... ?Is “Out of memory” an acceptable reason? :-)
It is ;)
> Thanks, here's a revised patch with Jakub's fix and yours. ?Is this one
> ok?
Yes.
Thanks,
Richard.
>
>
> --
> Alexandre Oliva, freedom fighter ? ?http://FSFLA.org/~lxoliva/
> You must be the change you wish to see in the world. -- Gandhi
> Be Free! -- http://FSFLA.org/ ? FSF Latin America board member
> Free Software Evangelist ? ? ?Red Hat Brazil Compiler Engineer
>
>