This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] [Revised] libiberty hashtab.c:hash_pointer() needs intptr_t


On Thu, Sep 3, 2009 at 6:47 PM, H.J. Lu<hjl.tools@gmail.com> wrote:
> On Thu, Sep 3, 2009 at 9:32 AM, Ian Lance Taylor<iant@google.com> wrote:
>> Ozkan Sezer <sezeroz@gmail.com> writes:
>>
>>> This is the revised version of a previously OK'ed[1] but unapplied patch;
>>> configure is now regenerated for autoconf 2.64. ?OK for trunk? ?[I don't
>>> have svn write access.]
>>>
>>> [1] http://gcc.gnu.org/ml/gcc-patches/2009-03/msg00780.html
>>>
>>> --
>>>
>>> 2009-09-03 ?Ozkan Sezer ?<sezeroz@gmail.com>
>>>
>>> ? ? ? PR target/39065
>>> ? ? ? * configure.ac: Also check for intptr_t.
>>> ? ? ? * config.h.in: Regenerated.
>>> ? ? ? * configure: Regenerated.
>>> ? ? ? * hashtab.c (hash_pointer): Cast the pointer argument to intptr_t
>>> ? ? ? instead of of long.
>>
>> I already OK'ed this patch. ?It's still OK.
>>
>> Anybody want to volunteer to apply it?
>>
>
> Checked into gcc and src.

This wasn't a regression fix and trunk is still closed for non-regression fixes.

AC_CHECK_TYPE(intptr_t, long)

and this is wrong for LLP64 targets (likewise the existing uintptr_t check).

Richard.

> --
> H.J.
>


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]