This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [v3] Fix race condition in libstdc++-v3/configure.ac


* Paolo Carlini wrote on Wed, Sep 02, 2009 at 12:00:16AM CEST:
> > No idea whether it is related; but I'd appreciate if you filed a bug
> > report, that way it won't fall under the carpet.  We can still merge
> > it or close it if it is the same.  Feel free to Cc: me in the PR.
> >   
> Done. It's libstdc++/41220, definitely a regression. Thanks in advance
> for your help!

Confirmed.  You can work around it with 'rm include/stamp-host' before
running 'make' again.  Patch below.

This issue existed before the autotools upgrade (verified with r151011).
I assume the non-regeneration of these headers is a long-standing issue,
only exposed through r150672 which introduced <extc++> inclusion into
the testsuite:

2009-08-11  Benjamin Kosnik  <bkoz@redhat.com>

        * include/precompiled/extc++.h: Don't include TR1 if C++0x.
[...]
        * testsuite/17_intro/headers/c++1998/all.cc: Use extc++.h include.

A 'git grep extc++ fbf4148e0248e4dfab55109dde400e848f76e43b^ -- testsuite'
shows that there were no uses of this header in the testsuite before that
commit.

OK to apply?

Thanks,
Ralf

libstdc++-v3/ChangeLog:
2009-09-02  Ralf Wildenhues  <Ralf.Wildenhues@gmx.de>

	* include/Makefile.am (CLEANFILES): Add stamp-host.
	* include/Makefile.in: Regenerate.

diff --git a/libstdc++-v3/include/Makefile.am b/libstdc++-v3/include/Makefile.am
index b0fc483..55d0236 100644
--- a/libstdc++-v3/include/Makefile.am
+++ b/libstdc++-v3/include/Makefile.am
@@ -1223,7 +1223,7 @@ install-headers:
 	  $(INSTALL_DATA) $${file} $(DESTDIR)${host_installdir}; done
 
 # By adding these files here, automake will remove them for 'make clean'
-CLEANFILES = ${pch_output} ${pch_output_anchors}
+CLEANFILES = ${pch_output} ${pch_output_anchors} stamp-host
 
 # To remove directories.
 clean-local:


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]