This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Don't schedule prefetch insns - take 2


Hi,

On Wed, 2 Sep 2009, Andreas Krebbel wrote:

> 	* rtl.h (PREFETCH_VOLATILE_P): New macro.	

I would suggest to not name this macro PREFETCH_VOLATILE_P just because it 
happens to use the volatil flag in struct rtx.  Perhaps 
PREFETCH_SCHEDULE_BARRIER_P or the like?

> Index: gcc/rtl.h
> ===================================================================
> *** gcc/rtl.h.orig	2009-08-17 11:17:57.000000000 +0200
> --- gcc/rtl.h	2009-09-02 15:44:32.000000000 +0200
> *************** do {						\
> *** 1382,1387 ****
> --- 1382,1390 ----

>      offset within that block.  */
>   #define SYMBOL_REF_BLOCK_OFFSET(RTX) (BLOCK_SYMBOL_CHECK (RTX)->offset)
>   
> + #define PREFETCH_VOLATILE_P(RTX)					\
> +   (RTL_FLAG_CHECK1("PREFETCH_VOLATILE_P", (RTX), PREFETCH)->volatil)
> + 

This usage of the bit needs a comment also in the large comment for each 
field of struct rtx in rtl.h for everyone to immediately see that it's 
taken also for PREFETCH rtx's.  The macro itself also needs a comment.


Ciao,
Michael.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]