This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: PATCH: Fix IRIX 6.5/Solaris 2 <complex.h> for GCC (PR libfortran/41169)


* Rainer Orth wrote on Wed, Sep 02, 2009 at 07:42:43PM CEST:
> > * Bruce Korb wrote on Wed, Sep 02, 2009 at 04:53:20PM CEST:
> > > On Wed, Sep 2, 2009 at 5:01 AM, Rainer Orth wrote:
> > > > + ? ?sed ? ? ? ? ? ? ?= "s/#define[ \t]_Complex_I[ \t]_Complex_I/"
> > > > + ? ? ? ? ? ? ? "#define\t_Complex_I\t\\(__extension__ 1.0iF\\)/";
> >
> > Why are there backslashes before ( and ) in this line?  That line is
> > part of the replacement text, so the backslashes will end up literally
> > in the output.
> 
> no, they don't, at least with GNU sed 4.1.4.  I've just tried this manually
> and checked the fixed complex.h in the 20090902 tree.

Guess you're right that it doesn't matter, but the backslashes are
certainly not needed here, so why not remove them to avoid confusion?
(I can do that, I'm preparing a larger fixincludes sed patch anyway.)

Cheers,
Ralf


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]