This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH][RFC] New function for checking misalignment
- From: Richard Guenther <richard dot guenther at gmail dot com>
- To: Revital1 Eres <ERES at il dot ibm dot com>
- Cc: gcc-patches at gcc dot gnu dot org, Michael Meissner <meissner at linux dot vnet dot ibm dot com>
- Date: Wed, 2 Sep 2009 16:53:22 +0200
- Subject: Re: [PATCH][RFC] New function for checking misalignment
- References: <OFAD76876A.8E62DFD2-ONC2257624.0060D507-C2257625.004FD585@il.ibm.com>
On Wed, Sep 2, 2009 at 4:32 PM, Revital1 Eres<ERES@il.ibm.com> wrote:
>
> Hello,
>
> This patch adds a new target hook for checking if unaligned access
> with a certain misalignment factor is supported by the target.
>
> Tested on powerpc64 and x86.
> OK for mainline? Comments are welcome.
The bool parameter to the targethook needs documenting. In fact
it sounds redundant - the misalignment parameter should be enough
here, no? And yes, the hook needs documenting in doc/tm.texi.
Thanks,
Richard.
> Thanks to Michael for providing initial feedback for the patch.
>
> Thanks,
> Revital
>
> ? ? ? ?* targhooks.c (default_builtin_support_vector_misalignment):
> ? ? ? ?New builtin function.
> ? ? ? ?* targhooks.h (default_builtin_support_vector_misalignment):
> ? ? ? ?Declare.
> ? ? ? ?* target.h (builtin_support_vector_misalignment):
> ? ? ? ?New field in struct gcc_target.
> ? ? ? ?* tree-vect-data-refs.c (vect_supportable_dr_alignment): Call
> ? ? ? ?new builtin function.
> ? ? ? ?* target-def.h (TARGET_SUPPORT_VECTOR_MISALIGNMENT):
> ? ? ? ?Define.
> ? ? ? ?* config/rs6000/rs6000.c
> ? ? ? ?(rs6000_builtin_support_vector_misalignment): New function.
> ? ? ? ?(TARGET_SUPPORT_VECTOR_MISALIGNMENT): Define.
>
>
> (See attached file: misalign_2_9.txt)