This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [RFA] Patch PR debug/41065

Le 29/08/2009 17:29, Jakub Jelinek a écrit :
> On Sat, Aug 29, 2009 at 05:20:26PM +0200, Dodji Seketeli wrote:
>>     Fix PR debug/41065
>>     
>>     gcc/ChangeLog:
>>     	PR debug/41065
>>     	* function.h (global_used_types_hash): Declare ...
>>     	* function.c (global_used_types_hash): ... new hash table for types
>>     	used at global scope.
> 
> Wouldn't a pointer_set_t rather than htab_t be a better choice?
> You never delete from the hash table, only insert into it and traverse it.

Yes probably. I chose a htab_t for the sake of consistency with
function::used_types_hash. That minimises the changes in
used_types_insert_helper. If I switch global_used_types_hash to a
pointer_set_t, shouldn't I change function::used_types_hash as well ? There
never seem to be any deletion on it either.

Thanks.

-- 
Dodji Seketeli
Red Hat
Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]