This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH, TESTSUITE]: Fix extra testsuite failures with -fpic/-fPIC.


From: "Dominique Dhumieres" <dominiq@lps.ens.fr>

Kaveh,

I don't see the failures you report on Darwin and, if I recall correctly,
Darwin uses -fpic as default, isn't it?

No I believe Darwin is -fpie by default, or accomplishes something similar through its notion of whether functions bind locally.





! { dg-final { scan-tree-dump-times "= f\(\)" 0 "optimized" } }


should be

! { dg-final { scan-tree-dump-times "= f \(\)" 0 "optimized" } }

and the tests cannot fail since there is no "f()" in the *.original file

That is indeed a pickle, but it's unrelated to my issue. You can see the failures I'm getting for -fpic/-fPIC here:


http://gcc.gnu.org/ml/gcc-testresults/2009-08/msg02222.html

The function 'f' is not inlined for me on x86_64-linux-gnu with -fpic:

<bb 2>:
 D.1553_2 = f ();

I think what may be happening is that, for the pattern above, tcl is interpreting the parentheses as regex special characters and then they evaluate to an empty regex. So the pattern here reduces to "= f" which does the job (by accident). It may be a backslash issue, I don't know if you need to add or remove slashes...

Anyway, I believe my patch is still correct. If you or Paul want to figure out and fix the regex to match the parens and whitespace that can be done separately.

       Regards,
       --Kaveh


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]