This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: Fix to PR41012
- From: Steven Bosscher <stevenb dot gcc at gmail dot com>
- To: Xinliang David Li <davidxl at google dot com>
- Cc: GCC Patches <gcc-patches at gcc dot gnu dot org>, Diego Novillo <dnovillo at google dot com>
- Date: Sun, 9 Aug 2009 09:52:29 +0200
- Subject: Re: Fix to PR41012
- References: <522e93240908082341j310891c6g9916b56a0c4dfd44@mail.gmail.com>
On Sun, Aug 9, 2009 at 8:41 AM, Xinliang David Li<davidxl@google.com> wrote:
> The attached patch is meant to fix 41012. With this patch,
> check_call_args will use the DECL_ARGUMENTS associated with the
> func_decl of the newly generated direct call to do the check, and it
> will match the actuals.
>
> One possible problem is that if there are other places (other than in
> check_call_args) setting the cannot_inline attribute to the indirect
> call,, the bit will be lost -- but this is probably a moot point.
>
>
> Bootstraped/Regression tested on x86_64/linux
>
> Ok to commit?
If you export check_call_args, you should probably rename it to
something more descriptive. Maybe "gimple_verify_call_arg_types"?
Ciao!
Steven