Re: [PATCH] asm goto fixes, C++ support

[Richard Henderson <rth at redhat dot com>]

On 08/05/2009 04:57 AM, Jakub Jelinek wrote:
> I've played a little bit with your patch (hope this one is the latest)
> and here is an incremental patch resulting from that.
> 1) the extend.texi changes wouldn't build

This was the only thing I'd fixed in my local copy.  =)

> 2) as reported by Jason Baron, kernel uses asm ("" : : ); and similar,
>     which according to the grammar should be ok, but were rejected by the
>     new patch.  asm ("" : : : ); used to be rejected only by the C FE,
>     not C++, I'd say we should parse it too.
> 3) on the other side, IMHO with asm goto we should require labels, i.e. the
>     asm goto ("..." : ... : ... : ... : label-list); form, we shouldn't
>     allow asm goto ("abc"); or asm goto ("abc %0" : : "r" (x));
> This patch also adds very lightly tested C++ parsing support.

Looks good to me, thanks.



r~