This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: VTA RTL patch review?
- From: Alexandre Oliva <aoliva at redhat dot com>
- To: Richard Henderson <rth at redhat dot com>
- Cc: GCC Patches <gcc-patches at gcc dot gnu dot org>
- Date: Wed, 05 Aug 2009 05:50:41 -0300
- Subject: Re: VTA RTL patch review?
- References: <or63djgol8.fsf@livre.oliva.athome.lsd.ic.unicamp.br> <4A737F01.3000505@redhat.com>
On Jul 31, 2009, Richard Henderson <rth@redhat.com> wrote:
> Since nondebug_dep_list_size includes the has_debug test, don't
> over-complicate the code by replicating that here. Which also
> suggests that the has_debug local variable in rank_for_schedule should
> also be removed in favour of MAY_HAVE_DEBUG_INSNS.
ACK, nondebug_dep_list_size is now dep_list_size.
>> +# define SCHED_DEBUG_INSNS_BEFORE_REORDER 1
> What's this?
/me looks around
Are you asking me? How would I know, sir? ;-)
> Is there any reason why we'd want this false?
Honestly, I don't remember. I *think* it was a successful experiment
that I failed to clean up, but there might be reasons why ports would
want to set it. If there are, I don't remember, and I guess we'll
eventually find out. Removed.
>> +/* Convenience predicates. */
>> +#define SCHEDULE_DEBUG_INSN_P(insn) \
>> + (DEBUG_INSN_P (insn) && DEBUG_INSN_SCHED_P (insn))
>> +#define BOUNDARY_DEBUG_INSN_P(insn) \
>> + (DEBUG_INSN_P (insn) && !DEBUG_INSN_SCHED_P (insn))
> Some expanded commentary would be very helpful here.
I thought the comments before DEBUG_INSN_SCHED_P, defined right above,
would have been enough. I can't think of comments that wouldn't be
highly redundant, but... Added.
--
Alexandre Oliva, freedom fighter http://FSFLA.org/~lxoliva/
You must be the change you wish to see in the world. -- Gandhi
Be Free! -- http://FSFLA.org/ FSF Latin America board member
Free Software Evangelist Red Hat Brazil Compiler Engineer