This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [patch,;ibgfortran] PR40853 I/O: Namelist read error


On Sat, Aug 1, 2009 at 16:53, Jerry DeLisle<jvdelisle@verizon.net> wrote:
> Hi all,
>
> This patch is trivial, though not obvious.
>
> The error occurred when the current name list object, nl, was set back to
> first_nl with this test case. ?The current object was at the end of the
> linked list of objects so there are no further objects to match and read.
> ?Checking for NULL catches this.
>
> This changes two test cases as well. ?The output error messages for those
> cases, 40 and 47, is adjusted. Honestly, I always thought that error message
> was odd before because it included only the name of the first_nl. ?I just
> did not "see" it until now.
>
> Regression tested on x86_64-unknown-linux-gnu. ?OK for trunk? ?I think we
> should also backport to 4.4. [aside: I see at least some major distributions
> now have moved to 4.4, so there may be less value going to 4.3, but it is an
> easy patch]

Ok, thanks for the patch.

As for 4.4, it's not a regression, so I'll leave it up to you.  4.3 is
old enough that I think we should strictly follow the regressions-only
rule.

-- 
Janne Blomqvist


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]