This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH 1/4, MIPS] Add r2 variant for *clear_upper32


Adam Nemet <anemet@caviumnetworks.com> writes:
> In the new pattern I am using "o" for the memory operand's constraint.  I am
> also changing the same thing for the *zero_extensidi2_dext pattern; these
> patterns are not applicable to mips16 and while the constraint amounts to m
> for non-mips16, there is no need for the extra checks performed by "W" (unless
> of course we want to keep the !ISA_HAS_EXT_INS and the ISA_HAS_EXT_INS
> patterns similar).

Yes, please keep "W" for "lwu" addresses.  Although it's true that the
extra checks are not currently needed in this case, "o" is probably even
more expensive.  And even if it isn't, there's no way this will have a
noticable effect on compilation speed.  I think the consistency of using
the same constraint everywhere is more important.

OK with that change, thanks.

Richard


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]