This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: Adjust the testsuite to reality for FreeBSD and C99 support
- From: Gerald Pfeifer <gerald at pfeifer dot com>
- To: gcc-patches at gcc dot gnu dot org, Richard Guenther <rguenther at suse dot de>
- Cc: Janis Johnson <janis187 at us dot ibm dot com>, "Loren J. Rittle" <ljrittle at acm dot org>, Uros Bizjak <ubizjak at gmail dot com>
- Date: Wed, 29 Jul 2009 14:34:53 +0200 (CEST)
- Subject: Re: Adjust the testsuite to reality for FreeBSD and C99 support
- References: <alpine.LSU.1.99.0907101328260.8877@acrux.dbai.tuwien.ac.at>
Hi Richard,
I was just going to commit a "backport" of this to the gcc-4.3 branch when
I saw your freeze note. This addresses a couple of dozen FAILs on FreeBSD
and it would be nice to see in the forthcoming release.
Before: http://gcc.gnu.org/ml/gcc-testresults/2009-07/msg02859.html
After: http://gcc.gnu.org/ml/gcc-testresults/2009-07/msg02901.html
Is this okay to commit, or do we need to wait until after the release?
Gerald
On Sun, 12 Jul 2009, Gerald Pfeifer wrote:
> Uros was so kind pointing out what looked like a discrepancy between what
> FreeBSD actually supports and what the testsuite assume and after some
> rounds of tests and investigations it really became clear that FreeBSD
> simply lacks some key C99 functions like cexp.
>
> This patch adjust the testsuite accordingly. It probably falls under the
> obvious rule, but I will wait a bit for comments and/or active approval.
>
> Tested on i386-unknown-freebsd7.2. Before:
> http://gcc.gnu.org/ml/gcc-testresults/2009-07/msg00597.html
> And after:
> http://gcc.gnu.org/ml/gcc-testresults/2009-07/msg00957.html
>
> Gerald
>
>
> 2009-07-09 Gerald Pfeifer <gerald@pfeifer.com>
>
> * gcc.dg/builtins-config.h (HAVE_C99_RUNTIME): Do not define
> for FreeBSD up to and including version 8.
>
> Index: gcc.dg/builtins-config.h
> ===================================================================
> --- gcc.dg/builtins-config.h (revision 149438)
> +++ gcc.dg/builtins-config.h (working copy)
> @@ -1,4 +1,4 @@
> -/* Copyright (C) 2003, 2004, 2005, 2006 Free Software Foundation.
> +/* Copyright (C) 2003, 2004, 2005, 2006, 2009 Free Software Foundation.
>
> Define macros useful in tests for bulitin functions. */
>
> @@ -15,8 +15,8 @@
> /* Irix6 doesn't have the entire C99 runtime. */
> #elif defined(__AVR__)
> /* AVR doesn't have the entire C99 runtime. */
> -#elif defined(__FreeBSD__) && (__FreeBSD__ < 5)
> -/* FreeBSD before version 5 doesn't have the entire C99 runtime. */
> +#elif defined(__FreeBSD__) && (__FreeBSD__ < 9)
> +/* FreeBSD up to version 8 lacks support for cexp and friends. */
> #elif defined(__netware__)
> /* NetWare doesn't have the entire C99 runtime. */
> #elif defined(__vxworks)