Re: [PATCH] Powerpc patch #5, Add power7/vsx support (fix bugs in patch #4)

[Uros Bizjak <ubizjak at gmail dot com>]

Hello!

> This patch is a respin of patch #4, that fixes the V2DImode problem on altivec
> that I noticed after submitting the patch, and to address the comments David
> made about patch #4 (using CONST0_RTX instead of const_int 0, and changing the
> UNSPEC number so it doesn't collide with rs6000.md).
>
>    

You don't need to handle BUILT_IN_{FABS, FMIN, FMAX}{,F} in target 
dependant vectorized_function. These builtins are already handled by 
generic code and will never reach this function as long as you have 
correct named patterns in the .md file.

> +static tree
> +rs6000_builtin_vectorized_function (unsigned int fn, tree type_out,
> +				    tree type_in)
> +{
> +  enum machine_mode in_mode, out_mode;
> +  int in_n, out_n;
> +
> +  if (TREE_CODE (type_out) != VECTOR_TYPE
> +      || TREE_CODE (type_in) != VECTOR_TYPE
> +      || !TARGET_VECTORIZE_BUILTINS)
> +    return NULL_TREE;
> +
> +  out_mode = TYPE_MODE (TREE_TYPE (type_out));
> +  out_n = TYPE_VECTOR_SUBPARTS (type_out);
> +  in_mode = TYPE_MODE (TREE_TYPE (type_in));
> +  in_n = TYPE_VECTOR_SUBPARTS (type_in);
> +
> +  switch (fn)
> +    {
> +    case BUILT_IN_COPYSIGN:
> +      if (VECTOR_UNIT_VSX_P (V2DFmode)
> +	&&  out_mode == DFmode&&  out_n == 2
> +	&&  in_mode == DFmode&&  in_n == 2)
> +	return rs6000_builtin_decls[VSX_BUILTIN_CPSGNDP];
> +      break;
> +    case BUILT_IN_COPYSIGNF:
> +      if (out_mode != SFmode || out_n != 4
> +	  || in_mode != SFmode || in_n != 4)
> +	break;
> +      if (VECTOR_UNIT_VSX_P (V4SFmode))
> +	return rs6000_builtin_decls[VSX_BUILTIN_CPSGNSP];
> +      if (VECTOR_UNIT_ALTIVEC_P (V4SFmode))
> +	return rs6000_builtin_decls[ALTIVEC_BUILTIN_COPYSIGN_V4SF];
> +      break;
> +    case BUILT_IN_SQRT:
> +      if (VECTOR_UNIT_VSX_P (V2DFmode)
> +	&&  out_mode == DFmode&&  out_n == 2
> +	&&  in_mode == DFmode&&  in_n == 2)
> +	return rs6000_builtin_decls[VSX_BUILTIN_XVSQRTDP];
> +      break;
> +    case BUILT_IN_SQRTF:
> +      if (VECTOR_UNIT_VSX_P (V4SFmode)
> +	&&  out_mode == SFmode&&  out_n == 4
> +	&&  in_mode == SFmode&&  in_n == 4)
> +	return rs6000_builtin_decls[VSX_BUILTIN_XVSQRTSP];
> +      break;
> +    case BUILT_IN_CEIL:
> +      if (VECTOR_UNIT_VSX_P (V2DFmode)
> +	&&  out_mode == DFmode&&  out_n == 2
> +	&&  in_mode == DFmode&&  in_n == 2)
> +	return rs6000_builtin_decls[VSX_BUILTIN_XVRDPIP];
> +      break;
> +    case BUILT_IN_CEILF:
> +      if (out_mode != SFmode || out_n != 4
> +	  || in_mode != SFmode || in_n != 4)
> +	break;
> +      if (VECTOR_UNIT_VSX_P (V4SFmode))
> +	return rs6000_builtin_decls[VSX_BUILTIN_XVRSPIP];
> +      if (VECTOR_UNIT_ALTIVEC_P (V4SFmode))
> +	return rs6000_builtin_decls[ALTIVEC_BUILTIN_VRFIP];
> +      break;
> +    case BUILT_IN_FLOOR:
> +      if (VECTOR_UNIT_VSX_P (V2DFmode)
> +	&&  out_mode == DFmode&&  out_n == 2
> +	&&  in_mode == DFmode&&  in_n == 2)
> +	return rs6000_builtin_decls[VSX_BUILTIN_XVRDPIM];
> +      break;
> +    case BUILT_IN_FLOORF:
> +      if (out_mode != SFmode || out_n != 4
> +	  || in_mode != SFmode || in_n != 4)
> +	break;
> +      if (VECTOR_UNIT_VSX_P (V4SFmode))
> +	return rs6000_builtin_decls[VSX_BUILTIN_XVRSPIM];
> +      if (VECTOR_UNIT_ALTIVEC_P (V4SFmode))
> +	return rs6000_builtin_decls[ALTIVEC_BUILTIN_VRFIM];
> +      break;
> +    case BUILT_IN_TRUNC:
> +      if (VECTOR_UNIT_VSX_P (V2DFmode)
> +	&&  out_mode == DFmode&&  out_n == 2
> +	&&  in_mode == DFmode&&  in_n == 2)
> +	return rs6000_builtin_decls[VSX_BUILTIN_XVRDPIZ];
> +      break;
> +    case BUILT_IN_TRUNCF:
> +      if (out_mode != SFmode || out_n != 4
> +	  || in_mode != SFmode || in_n != 4)
> +	break;
> +      if (VECTOR_UNIT_VSX_P (V4SFmode))
> +	return rs6000_builtin_decls[VSX_BUILTIN_XVRSPIZ];
> +      if (VECTOR_UNIT_ALTIVEC_P (V4SFmode))
> +	return rs6000_builtin_decls[ALTIVEC_BUILTIN_VRFIZ];
> +      break;
> +    case BUILT_IN_NEARBYINT:
> +      if (VECTOR_UNIT_VSX_P (V2DFmode)
> +	&&  flag_unsafe_math_optimizations
> +	&&  out_mode == DFmode&&  out_n == 2
> +	&&  in_mode == DFmode&&  in_n == 2)
> +	return rs6000_builtin_decls[VSX_BUILTIN_XVRDPI];
> +      break;
> +    case BUILT_IN_NEARBYINTF:
> +      if (VECTOR_UNIT_VSX_P (V4SFmode)
> +	&&  flag_unsafe_math_optimizations
> +	&&  out_mode == SFmode&&  out_n == 4
> +	&&  in_mode == SFmode&&  in_n == 4)
> +	return rs6000_builtin_decls[VSX_BUILTIN_XVRSPI];
> +      break;
> +    case BUILT_IN_RINT:
> +      if (VECTOR_UNIT_VSX_P (V2DFmode)
> +	&&  !flag_trapping_math
> +&&  out_mode == DFmode&&  out_n == 2
> +&&  in_mode == DFmode&&  in_n == 2)
> +        return rs6000_builtin_decls[VSX_BUILTIN_XVRDPIC];
> +      break;
> +    case BUILT_IN_RINTF:
> +      if (VECTOR_UNIT_VSX_P (V4SFmode)
> +	&&  !flag_trapping_math
> +&&  out_mode == SFmode&&  out_n == 4
> +&&  in_mode == SFmode&&  in_n == 4)
> +        return rs6000_builtin_decls[VSX_BUILTIN_XVRSPIC];
> +      break;
> +    case BUILT_IN_FABS:
> +      if (VECTOR_UNIT_VSX_P (V2DFmode)
> +	&&  out_mode == DFmode&&  out_n == 2
> +	&&  in_mode == DFmode&&  in_n == 2)
> +	return rs6000_builtin_decls[VSX_BUILTIN_XVABSDP];
> +      break;
> +    case BUILT_IN_FABSF:
> +      if (out_mode != SFmode || out_n != 4
> +	  || in_mode != SFmode || in_n != 4)
> +	break;
> +      if (VECTOR_UNIT_VSX_P (V4SFmode))
> +	return rs6000_builtin_decls[VSX_BUILTIN_XVABSSP];
> +      if (VECTOR_UNIT_ALTIVEC_P (V4SFmode))
> +	return rs6000_builtin_decls[ALTIVEC_BUILTIN_ABS_V4SF];
> +      break;
> +    case BUILT_IN_FMAX:
> +      if (VECTOR_UNIT_VSX_P (V2DFmode)
> +	&&  out_mode == DFmode&&  out_n == 2
> +	&&  in_mode == DFmode&&  in_n == 2)
> +	return rs6000_builtin_decls[VSX_BUILTIN_XVMAXDP];
> +      break;
> +    case BUILT_IN_FMAXF:
> +      if (out_mode != SFmode || out_n != 4
> +	  || in_mode != SFmode || in_n != 4)
> +	break;
> +      if (VECTOR_UNIT_VSX_P (V4SFmode))
> +	return rs6000_builtin_decls[VSX_BUILTIN_XVMAXSP];
> +      if (VECTOR_UNIT_ALTIVEC_P (V4SFmode))
> +	return rs6000_builtin_decls[ALTIVEC_BUILTIN_VMAXFP];
> +      break;
> +    case BUILT_IN_FMIN:
> +      if (VECTOR_UNIT_VSX_P (V2DFmode)
> +	&&  out_mode == DFmode&&  out_n == 2
> +	&&  in_mode == DFmode&&  in_n == 2)
> +	return rs6000_builtin_decls[VSX_BUILTIN_XVMINDP];
> +      break;
> +    case BUILT_IN_FMINF:
> +      if (out_mode != SFmode || out_n != 4
> +	  || in_mode != SFmode || in_n != 4)
> +	break;
> +      if (VECTOR_UNIT_VSX_P (V4SFmode))
> +	return rs6000_builtin_decls[VSX_BUILTIN_XVMINSP];
> +      if (VECTOR_UNIT_ALTIVEC_P (V4SFmode))
> +	return rs6000_builtin_decls[ALTIVEC_BUILTIN_VMINFP];
> +      break;
> +    default:
> +      ;
> +    }
> +  return NULL_TREE;
>    

Uros.