This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [patch][mudflap] Mudflap cleanup
On Fri, Jul 17, 2009 at 11:33 PM, Olatunji Ruwase<tjruwase@google.com> wrote:
>> Hm, what's this?
>>
>> + ?/* Enable pragma redefines. */
>> + ?targetm.handle_pragma_redefine_extname = true;
>> +
>>
>
> mudflap requires that pragma redefines be enabled. Asides enabling
> it for all targets in target-def.h, I could not think of a way to do this
> only for mudflap. I would appreciate any suggestions.
IMHO either mf-runtime.h should not use #pragma redefine_extname
(it could use asm("newname") with the same effect, available
unconditionally), or we should unconditionally enable this pragma.
Setting a target feature from non-target code looks bogus at least.
(An obvious fix for your patch would be to keep the flag_mudflap
check where it is).
Thanks,
Richard.