This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: RFA: Remove undocumented SH -mfmovd option
Christian BRUEL <christian.bruel@st.com> wrote:
> I propose to resurrect the option here. It keeps Nick's default setting
> fix and __FMOVD_ENABLED__ macro, which is nice, but restore the ability
> to use on other silicons.
>
> Also adding a new test to make sure that the compiler is able to
> generate fmov.d instruction under user request for architectures
> supporting it
>
> Is it OK ?
I see your point.
Although the patch looks fine, please refer the results of
your testing. Also the documentation change should be tested
with "make info dvi".
A few minor coding standard issues:
> +Enable the use of the instruction @code{fmovd}. Check @option{-mdalign} for
Two spaces are required after period.
> +Enable the use of 64-bit floating point registers in fmov instructions. See -mdalign if 64-bit alignment is required.
Same here.
> 2009-07-17 Christian Bruel <christian.bruel@st.com>
>
> * config/sh/sh.opt (-mfmovd): Resurrect and add -mdalign reference.
> * doc/invoke.texi (-mfmovd): Likewise.
> * config/sh/sh.h (TARGET_FMOVD, MASK_FMOVD): Remove default
> setting.
Perhaps maybe a mailer problem, the 2nd line has an extra
tab, line 3-5 have started with spaces instead of a tab and
the last line is wrapped unexpectedly. The ChangeLog entry
for the new test has similar white space problems.
Regards,
kaz