This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] New pass to partition single function into multiple (resubmission)


On Wed, Jul 15, 2009 at 10:59 PM, Diego Novillo<dnovillo@google.com> wrote:
> On Wed, Jul 15, 2009 at 16:55, Richard
> Guenther<richard.guenther@gmail.com> wrote:
>
>> Still feels like a hack to me that has its arms twisted too much into the
>> middle-end.
>
> Hm? ?How else would you do it? ?The transformation looks to split a
> function into chunks that can fit in arbitrary code segments. ?The
> middle end is where we keep the basic blocks of the function, so we
> traverse those and ask the target to tell us where to split the
> blocks.
>
> I don't see another way of implementing it. ?Doing it in md-reorg
> seems too late as you'd need to replicate a lot of code for every
> target that wanted to support this. ?But I have not really thought
> about the problem at length, so perhaps I'm missing something obvious.

There are just too many things that change assumptions everywhere.
Such as the overloading of NOTE_BASIC_BLOCK, for starts.  Not of my
(few) comments of
http://gcc.gnu.org/ml/gcc-patches/2009-05/msg00162.html have been
properly addressed. And there are still no test cases.

This should not go into the trunk in this form, sorry.

Ciao!
Steven


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]