This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Fix PR37053: Move tweaks of commutative precedence to target hook


On 07/10/2009 03:14 PM, Peter Bergner wrote:
On Fri, 2009-07-10 at 00:58 +0200, Paolo Bonzini wrote:
Note that it is already being done if reload_completed, just not if
reload_in_progress.  No matter how pleasant, it would be a surprise if
the attached patch worked without this change it includes:

-      if (! constrain_operands (1))
+      if (! constrain_operands (reload_completed))

(Note: I haven't tested it with the change, either).  On the other hand,
with the change there is a subtle difference in reload_as_needed now
(I'm not sure it matters).

Maxim, can you try it on m68k?

FYI, this bootstrapped and regtested with no errors on powerpc64-linux.

[patch at http://permalink.gmane.org/gmane.comp.gcc.patches/189115]


It also fixes the testcase. Ok for mainline and branches?

Paolo


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]