This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] Fix PR37053: Move tweaks of commutative precedence to target hook
2009/7/9 Paolo Bonzini <bonzini@gnu.org>:
>
>> Notice how we're doing a final bit of validation -- constrain_operands --
>> here rather than in the validate routines. ?We're assuming that if this
>> extra validation fails, we can simply call validate_replace_rtx again
>> to revert the change. ?But this isn't always true, because the
>> validation routines can "canonicalise" the resulting insn.
>> It would be more robust (and cleaner) to treat this replacement
>> in the same way as post-reload ones, and do the constrain_operands
>> in recog.c:insn_invalid_p.
>
> Note that it is already being done if reload_completed, just not if
> reload_in_progress.
Right, that's what I meant by "in the same way as the post-reload
ones". Sorry for the confusion!
Richard