This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [patch] beat location sense into fold (PR/40435)
- From: Manuel López-Ibáñez <lopezibanez at gmail dot com>
- To: Aldy Hernandez <aldyh at redhat dot com>
- Cc: rth at redhat dot com, gcc-patches at gcc dot gnu dot org
- Date: Thu, 9 Jul 2009 15:23:10 +0200
- Subject: Re: [patch] beat location sense into fold (PR/40435)
- References: <20090709123025.GA14304@redhat.com>
2009/7/9 Aldy Hernandez <aldyh@redhat.com>:
>
> The patch is over a megabyte long, and I'm sure no one wants to see it,
> let alone have it in their inbox. ?It is available in the link below for
> review. ?I can post it on request.
I am all for more precise location info, but I don't understand the
following change:
bool
-fold_builtin_next_arg (tree exp, bool va_start_p)
+fold_builtin_next_arg (location_t loc ATTRIBUTE_UNUSED,
+ tree exp, bool va_start_p)
{
tree fntype = TREE_TYPE (current_function_decl);
int nargs = call_expr_nargs (exp);
@@ -11995,7 +12086,8 @@ fold_builtin_next_arg (tree exp, bool va
The loc is indeed never used, so why bother? This occurs at least twice.
Cheers,
Manuel.