This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [diagnostics] kill %J specifier
- From: "H.J. Lu" <hjl dot tools at gmail dot com>
- To: Manuel López-Ibáñez <lopezibanez at gmail dot com>
- Cc: Gcc Patch List <gcc-patches at gcc dot gnu dot org>, Gabriel Dos Reis <gdr at integrable-solutions dot net>
- Date: Tue, 7 Jul 2009 06:21:54 -0700
- Subject: Re: [diagnostics] kill %J specifier
- References: <6c33472e0907061938q1fd0f8a3u64424d5d6a2c5ef3@mail.gmail.com>
On Mon, Jul 6, 2009 at 7:38 PM, Manuel
López-Ibáñez<lopezibanez@gmail.com> wrote:
> The following patch removes all uses of %J. A follow-up patch will
> remove %J itself.
>
> Bootstrapped and regression tested x86_64-unknown-linux-gnu.
>
> OK for trunk?
>
> 2009-07-07 ?Manuel López-Ibáñez ?<manu@gcc.gnu.org>
>
> ? ? ? ?* cgraphunit.c: Replace %J by an explicit location. Update all
> ? ? ? ?calls.
> ? ? ? ?* c-decl.c: Likewise.
> ? ? ? ?* function.c: Likewise.
> ? ? ? ?* varasm.c: Likewise.
> ? ? ? ?* tree-ssa.c: Likewise.
> ? ? ? ?* c-common.c: Likewise.
> ? ? ? ?* tree-cfg.c: Likewise.
> ? ? ? ?* config/spu/spu.c: Likewise.
> ? ? ? ?* config/ia64/ia64.c: Likewise.
> ? ? ? ?* config/v850/v850.c: Likewise.
> java/
> ? ? ? ?* class.c: Replace %J by an explicit location. Update all calls.
> objc/
> ? ? ? ?* objc-act.c: Replace %J by an explicit location. Update all
> ? ? ? ?calls.
> cp/
> ? ? ? ?* init.c: Replace %J by an explicit location. Update all calls.
> ? ? ? ?* decl.c: Likewise.
> ? ? ? ?* typeck2.c: Likewise.
> ? ? ? ?* pt.c: Likewise.
> ? ? ? ?* name-lookup.c: Likewise.
>
ia64.c change in
http://gcc.gnu.org/viewcvs/trunk/gcc/config/ia64/ia64.c?r1=149312&r2=149311&pathrev=149312
has
@@ -607,8 +608,9 @@
break;
case FUNCTION_DECL:
- error ("%Jaddress area attribute cannot be specified for functions",
- decl);
+ error_at (DECL_SOURCE_LOCATION (decl),
+ "address area attribute cannot be specified for functions",
+ decl);
*no_add_attrs = true;
break;
There is an extra 'decl', which breaks ia64. I will check in the following patch
if it fixes bootstrap.
--
H.J.
---
Index: config/ia64/ia64.c
===================================================================
--- config/ia64/ia64.c (revision 149322)
+++ config/ia64/ia64.c (working copy)
@@ -609,8 +609,8 @@ ia64_handle_model_attribute (tree *node,
case FUNCTION_DECL:
error_at (DECL_SOURCE_LOCATION (decl),
- "address area attribute cannot be specified for functions",
- decl);
+ "address area attribute cannot be specified for "
+ "functions");
*no_add_attrs = true;
break;