This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [Patch, fortran] PR40646 - ICE assigning array return value from type-bound procedure

From: Tobias Burnus <burnus at net-b dot de>
To: Janus Weil <janus at gcc dot gnu dot org>
Cc: Paul Richard Thomas <paul dot richard dot thomas at gmail dot com>, fortran at gcc dot gnu dot org, gcc-patches <gcc-patches at gcc dot gnu dot org>
Date: Sat, 04 Jul 2009 15:02:22 +0200
Subject: Re: [Patch, fortran] PR40646 - ICE assigning array return value from type-bound procedure
References: <339c37f20907040521h11c89044q24b3a54f3e200b52@mail.gmail.com> <854832d40907040557p3c7d97ffhbbfd2650c9e7236f@mail.gmail.com>

Janus Weil wrote:
> One small question though: Is there a special reason for your second
> hunk in gfc_trans_arrayfunc_assign? It should do exactly the same as
> before, I think. Or do I miss something? I'm just curious, since I'm
> the author of the code you're changing :)
>   
Well, for intrinsic functions, you save one function call:

-  is_proc_ptr_comp(expr2, &comp);
   gcc_assert (expr2->value.function.isym
-	      || (comp && comp->attr.dimension)
+	      || (is_proc_ptr_comp(expr2, &comp) && comp && comp->attr.dimension)


Side note: There is a " " missing after "is_proc_ptr_comp".

Tobias

References:
- [Patch, fortran] PR40646 - ICE assigning array return value from type-bound procedure
  - From: Paul Richard Thomas
- Re: [Patch, fortran] PR40646 - ICE assigning array return value from type-bound procedure
  - From: Janus Weil

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]