This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [8/8] Tidy up testsuite handling of LD_LIBRARY_PATH (needs testsuite maintainer)
On Thu, 2009-07-02 at 20:38 +0100, Richard Sandiford wrote:
> I just wanted to say a public "sorry" for all the fallout from this patch.
> Something obviosly went wrong with my testing.
Testsuite infrastructure cleanups usually break something somewhere,
but thanks for handling it quickly.
> David Edelsohn <dje.gcc@gmail.com> writes:
> > The appended patch fixes libgomp for me. I do not know if there is a
> > better / cleaner way. I tried setting TARGET_OPTIONS to -pthread for
> > target AIX, but that did not seem to affect the multilib directory
> > choice.
>
> libgomp stores various libgomp-specific options in a variable called
> ALWAYS_CFLAGS. These options are then used in every compilation test.
> The problem is that the same options aren't included when running
> "$cc --print-multi-lib", so the compiler isn't aware that
> we're using -fopenmp, and thus need pthreads.
>
> The patch below "fixes" this. I sent it to David privately because the
> AIX machine I use is down at the moment, and he confirms it fixes the
> problem (thanks!). OK to install?
OK.
Janis