This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [8/8] Tidy up testsuite handling of LD_LIBRARY_PATH (needs testsuite maintainer)


Richard,

This patch actually breaks some of the testsuite on AIX.

> The patch adds a new function, find_libgcc_s, that finds the
> libgcc_s directory for the current multilib.  The patch also adds a
> utility function called add_path for adding new components to a path.
> This function is a no-op if the new component is empty, avoiding the
> empty path problem mentioned in (2) above.

This design is fine for 32/64, but makes an incorrect assumption about
pthread support.  Some components in GCC, such as libgomp, always are
built with pthreads enabled -- the pthread and non-pthread multilibs
are identical.  By default, the testsuite runs in 32 bit, non-pthread
mode, so the explicit overriding of LD_LIBRARY_PATH does not insert
the pthread directory and all tests fail.  The original logic added
pthread because libgomp requires pthreads.

David


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]