This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] fix PR40957, PPC breakage in emit_store_flag
- From: "H.J. Lu" <hjl dot tools at gmail dot com>
- To: Peter Bergner <bergner at vnet dot ibm dot com>
- Cc: Paolo Bonzini <paolo dot bonzini at gmail dot com>, GCC Patches <gcc-patches at gcc dot gnu dot org>, Janis Johnson <janis187 at us dot ibm dot com>
- Date: Wed, 1 Jul 2009 21:17:00 -0700
- Subject: Re: [PATCH] fix PR40957, PPC breakage in emit_store_flag
- References: <4A4BA38A.6050109@gmail.com> <1246502300.5430.13.camel@otta>
On Wed, Jul 1, 2009 at 7:38 PM, Peter Bergner<bergner@vnet.ibm.com> wrote:
> On Wed, 2009-07-01 at 19:57 +0200, Paolo Bonzini wrote:
>> PPC sometimes calls emit_store_flag with a target whose mode is not
>> SImode (i.e. the result mode of cstore optabs). ?In this case, when
>> emit_store_flag calls recursively we have to preserve the mode. ?To do
>> so when the recursive call has a NULL target, I added a target_mode
>> argument to emit_cstore and emit_store_flag_1.
>>
>> Bootstrapped powerpc64-linux-gnu (biarch, default 32-bit) by Peter
>> Bergner, okay?
>
> The default 64-bit (ie, --with-cpu=default64) also bootstrapped with no errors.
> Looking at the testsuite results for both the default32 and default64 builds
> against r149023 (the revision just before the cond-optab commit), the default32
> results show no regressions. ?However, the default64 shows 2 differences:
>
> 1) FAIL: gcc.dg/20020425-1.c (test for excess errors) [for both -m32 and -m64]
>
> ? Executing on host: /home/bergner/gcc/PR40597/build/gcc-mainline-base-64/gcc/xgcc -B/home/bergner/gcc/PR40597/build/gcc-mainline-base-64/gcc/ /home/bergner/gcc/PR40597/gcc-mainline-base/gcc/testsuite/gcc.dg/20020425-1.c ? ?-ansi -pedantic-errors -S ?-m32 -o 20020425-1.s ? ?(timeout = 1200)
> ? xgcc: Internal error: Segmentation fault (program cc1)
> ? Please submit a full bug report.
> ? See <http://gcc.gnu.org/bugs.html> for instructions.
> ? compiler exited with status 1
> ? output is:
> ? xgcc: Internal error: Segmentation fault (program cc1)
> ? Please submit a full bug report.
> ? See <http://gcc.gnu.org/bugs.html> for instructions.
>
> I'm building a debug compiler and will get a backtrace. ?The backtrace gdb
> gave me with this cc1 seemed corrupted.
>
> 2)
> ? Running target unix/-m32
> ? -FAIL: abi_check
> ? +FAIL: 21_strings/basic_string/cons/char/1.cc execution test
> ? +FAIL: 21_strings/basic_string/cons/wchar_t/1.cc execution test
> ? +FAIL: 21_strings/basic_string/init-list.cc execution test
> ? +FAIL: 21_strings/basic_string/insert/char/1.cc execution test
> ? ...
> ? +FAIL: ext/pb_ds/regression/trie_data_map_rand.cc execution test
> ? +FAIL: ext/pb_ds/regression/trie_no_data_map_rand.cc execution test
> ? +FAIL: ext/vstring/init-list.cc execution test
I was wondering if those 32bit failures were related to:
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=40613
--
H.J.