This is the mail archive of the
mailing list for the GCC project.
Re: Path ping
- From: Richard Guenther <rguenther at suse dot de>
- To: Jan Hubicka <hubicka at ucw dot cz>
- Cc: gcc-patches at gcc dot gnu dot org
- Date: Tue, 30 Jun 2009 15:55:55 +0200 (CEST)
- Subject: Re: Path ping
- References: <20090630125836.GB27611@kam.mff.cuni.cz>
On Tue, 30 Jun 2009, Jan Hubicka wrote:
> I would like to ping:
Hm, do you really need the virtual PHI handling here:
! /* Since we don't track liveness of virtual PHI nodes, it is possible
! rendered some PHI nodes unreachable while they are still in use.
! Mark them for renaming. */
! if (cfg_altered)
! basic_block next_bb;
In fact I fail to see why if then only PHIs are necessary
to be dealt with here...
In fact, remove_bb is careful to remove stmts via release_defs /
gsi_remove (but it doesn't call unlink_stmt_vdefs which it probably
should and this might fix it...?).
Anyway, the patch looks good apart from that virtual PHI business.
Can you update it to current trunk and try adding
if (gimple_vdef (stmt))
in tree-cfg.c:remove_bb (before the release_defs call, inside the
And remove all the virtual PHI handling from the patch?