This is the mail archive of the
mailing list for the GCC project.
Re: [Patch] Factor self-referential size trees into functions
On 06/29/2009 12:34 PM, Eric Botcazou wrote:
> A nit: I don't like find_substitute_in_expr being in tree.c and I don't
> like its name.
It's the natural place though, alongside the related substitute_in_expr and
substitute_placeholder_in_expr. As for the name, find_placeholder_in_expr
would probably be better indeed.
Yeah, with that name it fits better in tree.c.
> If I understand the patch correctly, this is a one-liner and could be
> submitted separately (personally, I would have no problem if the rest of
> the patch was approved by an Ada maintainer, or if you just went ahead
> and committed it).
No, it's not a one-liner, several places are touched.
Yeah, I missed process_call_operands. Anyway Richi already approved
that part separately.
> Roughly, what is the asymptotic complexity of multiple levels of
> discriminated types?
In terms of what?
I don't know, I guess in terms of nesting.
> Would this patch help with problems like the one you recently posted a patch
> for? (Just two curiosities).
Sorry, which patch exactly?
I was thinking of the walk_tree patch. Of course that does not have
anything to do with discriminated types, but I remember seeing patches
to cure exponential cost of discriminated types because they were