This is the mail archive of the
mailing list for the GCC project.
Re: [PATCH] Fix PR37053: Move tweaks of commutative precedence to target hook
- From: Peter Bergner <bergner at vnet dot ibm dot com>
- To: Maxim Kuvyrkov <maxim at codesourcery dot com>
- Cc: gcc-patches <gcc-patches at gcc dot gnu dot org>, Paolo Bonzini <bonzini at gnu dot org>, Ian Lance Taylor <iant at google dot com>, Luis Machado <luisgpm at linux dot ibm dot com>
- Date: Fri, 26 Jun 2009 11:28:26 -0500
- Subject: Re: [PATCH] Fix PR37053: Move tweaks of commutative precedence to target hook
- References: <4A44D817.firstname.lastname@example.org> <1246031128.5284.45.camel@otta> <4A44F178.email@example.com>
On Fri, 2009-06-26 at 20:04 +0400, Maxim Kuvyrkov wrote:
> Peter Bergner wrote:
> > In the mean time, I have asked Luis to test your patch on POWER6 to ensure
> > there are no performance degradations. It doesn't look like there should
> > be, but...
> The assembler should be exactly the same. If it isn't, then there's a
> bug in the patch.
That's exactly what we're testing for. With your patch, we'll always
decrement the precedence value if we have a pointer. With the old code,
that occurred only for RTX_OBJ. Maybe that's the only case were we'll
see pointers, but I personally don't know that for sure.