This is the mail archive of the mailing list for the GCC project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Fix emit_library_call_value to not use virtual stack regs after expand

Steven Bosscher wrote:
On Wed, Jun 24, 2009 at 2:11 PM, Maxim Kuvyrkov<> wrote:

The following simple patch [which is just a duplication of a hunk from
within emit_library_call_value_1] fixes ICE when compiling for m68k/ColdFire
machines without hardware divide.

The ICE occurs in reload on gcc.c-torture/execute/loop-3b.c test due to
occurrence of virtual_outgoing_args_rtx in the instruction stream.  This
virtual register is used within expand and then is substituted with
(stack_pointer_rtx + STACK_POINTER_OFFSET) at the end of expand.

Evidently, there still remains a way to generate virtual_outgoing_args by
the loop optimizer.  The loop optimizer emits a divide instruction which,
due to target not having hwdiv, expands into a library call.

emit_library_call_value_1 deals with virtual_outgoing_args_rtx in two
places: the first already handles case when virtuals are instantiated; this
patch fixes the second.

Tested by bootstrapping on x86_64. OK for trunk?

It was my understanding that the expanders should never be used after 'expand', but to get this libcall you have to go through an expander, right?

I don't think I understand you on this. Most instructions emitted after the expand pass are emitted via expand_<op>, so expanders are used, and quite extensively, after the expand pass; and there also are functions like expand_binop -- this one is being used in RTL loop optimizer to generate a divide. I suppose you mean something under 'expander'.

So maybe the bug is in the loop optimizer -- it shouldn't try to do
its transformations if it has to do them via expanders.

Again, how to generate instructions then?


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]