This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH][Ada][PING] Use timeout for ACATS when available


On Wed, 2009-06-24 at 10:18 +0200, Arnaud Charlet wrote:
> > Anyway, this 2004 patch hasn't been approved by Ada maintainers
> > any more than my patch so we have to live with local patches for a while
> > more...
> 
> I've reconsidered since then, and as I told you on your patch submission,
> the 2004 patch now does look reasonable to me.
> 
> In 2004, we didn't have any expect based Ada test suite, so requiring expect
> looked like an additional unnecessary burden to me. Since then, we've introduced
> a complete Ada test suite based on expect, so there's no additional burden
> any more.
> 
> The patch needs to be updated and retested, so I'd suggest doing so and
> resend an updated patch submission, which I'll then approve if nothing
> unexpected shows up on your testing.

Thanks for the review. I'll give the expect patch a new test when
some form the gnatmake and gnatlink patches are reviewed and in.

Laurent



Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]