This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

[PATCH, committed] Power7 changes, part 1, infrastructure changes


On Fri, Jun 19, 2009 at 09:25:26PM -0400, David Edelsohn wrote:
> Part 1 of the changes is okay so far.
> 
> I think it would have been better to make all of the changes to
> rs6000_init_hard_regno_mode_ok() at the beginning.
> 
> A couple of typos:
> 
> In rs6000_init_hard_regno_mode_ok()
> 
> +  /* Precalculate CLASSS_MAX_NREGS sizes.  */
> +  for (c = 0; c < LIM_REG_CLASSES; ++c)
> 
> One too many SSS's in CLASSS_MAX_NREGS comment.
> 
> 
> In rs6000.h
> 
> +/* VSX register classes.  */
> +extern enum reg_class rs6000_vector_reg_class[];
> 
> The comment needs to be updated to the later use of the array.

I fixed the typos, and reworked the comment on rs6000_vector_reg_class, and
checked in the patches for the first patch.  I'll include the two patches as an
attachment.

-- 
Michael Meissner, IBM
4 Technology Place Drive, MS 2203A, Westford, MA, 01886, USA
meissner@linux.vnet.ibm.com

Attachment: gcc-power7-mainline.patch10-01
Description: Text document

Attachment: gcc-power7-mainline.patch10-01b
Description: Text document


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]