This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] Power7 changes, part 1, infrastructure changes
- From: David Edelsohn <dje dot gcc at gmail dot com>
- To: Michael Meissner <meissner at linux dot vnet dot ibm dot com>
- Cc: gcc-patches <gcc-patches at gcc dot gnu dot org>
- Date: Fri, 19 Jun 2009 21:25:26 -0400
- Subject: Re: [PATCH] Power7 changes, part 1, infrastructure changes
Part 1 of the changes is okay so far.
I think it would have been better to make all of the changes to
rs6000_init_hard_regno_mode_ok() at the beginning.
A couple of typos:
In rs6000_init_hard_regno_mode_ok()
+ /* Precalculate CLASSS_MAX_NREGS sizes. */
+ for (c = 0; c < LIM_REG_CLASSES; ++c)
One too many SSS's in CLASSS_MAX_NREGS comment.
In rs6000.h
+/* VSX register classes. */
+extern enum reg_class rs6000_vector_reg_class[];
The comment needs to be updated to the later use of the array.
Thanks, David